Fix: distributed sampler for multi GPU #3053
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…o Ori-Distributed-Sampler-Fix
for more information, see https://pre-commit.ci
…o Ori-Distributed-Sampler-Fix # Conflicts: # tests/dataloaders/test_dataloaders.py
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3053 +/- ##
==========================================
- Coverage 90.06% 84.61% -5.45%
==========================================
Files 178 178
Lines 15125 15126 +1
==========================================
- Hits 13622 12799 -823
- Misses 1503 2327 +824
|
…atches between gpus
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…o Ori-Distributed-Sampler-Fix
…o Ori-Distributed-Sampler-Fix
ori-kron-wis
changed the title
| @@ -45,6 +53,12 @@ def __init__( | |||
| self._shuffle = shuffle | |||
| self._batch_size = batch_size | |||
| self._drop_last = drop_last | |||
| self._distributed_sampler = distributed_sampler | |||
| # self._drop_dataset_tail = ( | |||
There was a problem hiding this comment.
Do we still need this? Drop_last should have the same effect?
| @@ -124,6 +124,7 @@ def __init__( | |||
| drop_last=drop_last, | |||
| drop_dataset_tail=drop_dataset_tail, | |||
| shuffle=shuffle, | |||
| # **kwargs, | |||
ori-kron-wis
added
multiGPU tests
ori-kron-wis
added
on-merge: backport to 1.2.x
|
multi gpu tests not working in the runner, but do locally, will continue with this in scvi tools v1.3 to work with other models |
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
Update for the dataloader in case of distributed sampler
close #3047